Repository navigation
fix: guard app update notifications when running outside an app bundle - #33
Conversation
When the binary is run outside a `.app` bundle (e.g. `swift run` / CLI / tests), `UNUserNotificationCenter.current()` is not a valid host context, and instantiating it plus setting its delegate can throw/crash before the app is even usable. Treat the notification center as optional and no-op the service when not running from an app bundle. - AppUpdateNotificationService: type `notificationCenter` as optional (`UNUserNotificationCenter?`); assign it only when `isRunningFromAppBundle` is true, otherwise `nil`, and switch the delegate assignment to optional chaining - `removeNotificationIfInstalled` / `notifyUpdateReady`: early-return when `notificationCenter` is nil so non-bundle runs skip notification work - `requestAuthorizationAndNotify` / `deliverUpdateReadyNotification`: on a nil center, finalize the in-flight attempt as failed instead of dereferencing - Add `isRunningFromAppBundle` helper checking `Bundle.main.bundleURL.pathExtension == "app"` Co-Authored-By: Claude <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
When the binary is run outside a
.appbundle (e.g.swift run/ CLI / tests),UNUserNotificationCenter.current()is not a valid host context, and instantiating it plus setting its delegate can throw/crash before the app is even usable. Treat the notification center as optional and no-op the service when not running from an app bundle.notificationCenteras optional (UNUserNotificationCenter?); assign it only whenisRunningFromAppBundleis true, otherwisenil, and switch the delegate assignment to optional chainingremoveNotificationIfInstalled/notifyUpdateReady: early-return whennotificationCenteris nil so non-bundle runs skip notification workrequestAuthorizationAndNotify/deliverUpdateReadyNotification: on a nil center, finalize the in-flight attempt as failed instead of dereferencingisRunningFromAppBundlehelper checkingBundle.main.bundleURL.pathExtension == "app"Co-Authored-By: Claude noreply@anthropic.com