Skip to content

fix: guard app update notifications when running outside an app bundle - #33

Merged
lonewolfyx merged 1 commit into
mainfrom
fix/app-update-notification-non-bundle-guard
Jul 16, 2026
Merged

lonewolfyx merged 1 commit into
mainfrom
fix/app-update-notification-non-bundle-guard

Conversation

@lonewolfyx

@lonewolfyx lonewolfyx commented Jul 16, 2026 •

Copy link
Copy Markdown
Member

When the binary is run outside a .app bundle (e.g. swift run / CLI / tests), UNUserNotificationCenter.current() is not a valid host context, and instantiating it plus setting its delegate can throw/crash before the app is even usable. Treat the notification center as optional and no-op the service when not running from an app bundle.

  • AppUpdateNotificationService: type notificationCenter as optional (UNUserNotificationCenter?); assign it only when isRunningFromAppBundle is true, otherwise nil, and switch the delegate assignment to optional chaining
  • removeNotificationIfInstalled / notifyUpdateReady: early-return when notificationCenter is nil so non-bundle runs skip notification work
  • requestAuthorizationAndNotify / deliverUpdateReadyNotification: on a nil center, finalize the in-flight attempt as failed instead of dereferencing
  • Add isRunningFromAppBundle helper checking Bundle.main.bundleURL.pathExtension == "app"

Co-Authored-By: Claude noreply@anthropic.com

When the binary is run outside a `.app` bundle (e.g. `swift run` / CLI / tests), `UNUserNotificationCenter.current()` is not a valid host context, and instantiating it plus setting its delegate can throw/crash before the app is even usable. Treat the notification center as optional and no-op the service when not running from an app bundle.

- AppUpdateNotificationService: type `notificationCenter` as optional (`UNUserNotificationCenter?`); assign it only when `isRunningFromAppBundle` is true, otherwise `nil`, and switch the delegate assignment to optional chaining
- `removeNotificationIfInstalled` / `notifyUpdateReady`: early-return when `notificationCenter` is nil so non-bundle runs skip notification work
- `requestAuthorizationAndNotify` / `deliverUpdateReadyNotification`: on a nil center, finalize the in-flight attempt as failed instead of dereferencing
- Add `isRunningFromAppBundle` helper checking `Bundle.main.bundleURL.pathExtension == "app"`

Co-Authored-By: Claude <noreply@anthropic.com>
@lonewolfyx
lonewolfyx merged commit 03546a4 into main Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@lonewolfyx, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a2b658d1-dd2b-47cc-8f7c-790b4a576e57

📥 Commits

Reviewing files that changed from the base of the PR and between 058e06d and 6f4489c.

📒 Files selected for processing (1)
  • Sources/AgentBar/Services/AppUpdateNotificationService.swift
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/app-update-notification-non-bundle-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lonewolfyx
lonewolfyx deleted the fix/app-update-notification-non-bundle-guard branch July 16, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant