Repository navigation
feat: localize the weekly quota menu bar prefix - #32
Merged
Merged
Conversation
Replace the hardcoded "1w" weekly-quota prefix shown in the menu bar with a localized `shortWeek` string, so the prefix follows the app language instead of always rendering the English abbreviation. - I18n: add `shortWeek` key — en "Weekly", zh-Hans "周剩" - CodexRateLimitService: return `I18n.current.shortWeek` for the 10080-min (1w) rate-limit window instead of the literal "1w" - MenuBarQuotaView: use `I18n.current.shortWeek` for both the initial label and the empty-snapshot fallback, dropping the remaining "1w" literals Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR adds a localized ChangesLocalized weekly labels
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded "1w" weekly-quota prefix shown in the menu bar with a localized
shortWeekstring, so the prefix follows the app language instead of always rendering the English abbreviation.shortWeekkey — en "Weekly", zh-Hans "周剩"I18n.current.shortWeekfor the 10080-min (1w) rate-limit window instead of the literal "1w"I18n.current.shortWeekfor both the initial label and the empty-snapshot fallback, dropping the remaining "1w" literalsCo-Authored-By: Claude noreply@anthropic.com
Summary by CodeRabbit