Skip to content

test(tui): six terminal tests no longer follow the developer's terminal #6979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hmbown merged 3 commits into from
Oct 15, 2026
Merged

test(tui): six terminal tests no longer follow the developer's terminal #6979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4689ff3
test(tui): six terminal tests no longer follow the developer's terminal
Lstarsky0 Oct 14, 2026
ff96b66
Merge branch 'main' into test/terminal-tests-ignore-ambient-markers
Lstarsky0 Oct 15, 2026
341b062
test(tui): carry the multiplexer guards to the moved Ghostty config test
Lstarsky0 Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/tui/src/commands/config_main_host.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4122,6 +4122,10 @@ mod tests {
));
fs::create_dir_all(&temp_root).unwrap();
let _guard = EnvGuard::new(&temp_root);
let _tmux = EnvVarGuard::remove("TMUX");
let _sty = EnvVarGuard::remove("STY");
let _tilix_id = EnvVarGuard::remove("TILIX_ID");
let _terminator_uuid = EnvVarGuard::remove("TERMINATOR_UUID");
// Neutralize the SSH markers: production intentionally caps motion
// over SSH, and the suite routinely runs inside one.
let _ssh_client = EnvVarGuard::remove("SSH_CLIENT");
Expand Down
3 changes: 3 additions & 0 deletions crates/tui/src/commands/session_export_regression_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ struct ExportHarness {
// temporary files are removed (matches ControlHarness).
_home: EnvVarGuard,
_codewhale_home: EnvVarGuard,
_ssh: [EnvVarGuard; 3],
_env_lock: TestEnvLock,
temp: TempDir,
}
Expand All @@ -54,6 +55,7 @@ impl ExportHarness {
std::fs::create_dir_all(&home).expect("home dir");
let _home = EnvVarGuard::set("HOME", &home);
let _codewhale_home = EnvVarGuard::set("CODEWHALE_HOME", &home);
let _ssh = ["SSH_CLIENT", "SSH_CONNECTION", "SSH_TTY"].map(EnvVarGuard::remove);
let options = TuiOptions {
skills_dir: temp.path().join("skills"),
memory_path: temp.path().join("memory.md"),
Expand All @@ -66,6 +68,7 @@ impl ExportHarness {
app,
_home,
_codewhale_home,
_ssh,
_env_lock: env_lock,
temp,
}
Expand Down
12 changes: 12 additions & 0 deletions crates/tui/src/settings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4531,6 +4531,11 @@ zai = ["GLM-5.2", "GLM-5.3"]
#[test]
fn ghostty_term_program_keeps_full_motion_without_the_legacy_30_fps_cap() {
let _g = term_program_test_guard();
let _tmux = crate::test_support::EnvVarGuard::remove("TMUX");
let _sty = crate::test_support::EnvVarGuard::remove("STY");
let _tilix_id = crate::test_support::EnvVarGuard::remove("TILIX_ID");
let _terminator_uuid = crate::test_support::EnvVarGuard::remove("TERMINATOR_UUID");
let _no_animations = crate::test_support::EnvVarGuard::remove("NO_ANIMATIONS");
// Neutralize the SSH markers: production intentionally caps motion
// over SSH, and the suite routinely runs inside one.
let _ssh_client = crate::test_support::EnvVarGuard::remove("SSH_CLIENT");
Expand Down Expand Up @@ -4559,6 +4564,11 @@ zai = ["GLM-5.2", "GLM-5.3"]
#[test]
fn ghostty_term_fallback_keeps_full_motion_without_the_legacy_30_fps_cap() {
let _g = term_program_test_guard();
let _tmux = crate::test_support::EnvVarGuard::remove("TMUX");
let _sty = crate::test_support::EnvVarGuard::remove("STY");
let _tilix_id = crate::test_support::EnvVarGuard::remove("TILIX_ID");
let _terminator_uuid = crate::test_support::EnvVarGuard::remove("TERMINATOR_UUID");
let _no_animations = crate::test_support::EnvVarGuard::remove("NO_ANIMATIONS");
// Neutralize the SSH markers: production intentionally caps motion
// over SSH, and the suite routinely runs inside one.
let _ssh_client = crate::test_support::EnvVarGuard::remove("SSH_CLIENT");
Expand Down Expand Up @@ -4592,6 +4602,7 @@ zai = ["GLM-5.2", "GLM-5.3"]
#[test]
fn non_vscode_term_program_does_not_force_low_motion() {
let _g = term_program_test_guard();
let _no_animations = crate::test_support::EnvVarGuard::remove("NO_ANIMATIONS");
let prev = std::env::var_os("TERM_PROGRAM");
let prev_term = std::env::var_os("TERM");
let prev_ssh_client = std::env::var_os("SSH_CLIENT");
Expand Down Expand Up @@ -4659,6 +4670,7 @@ zai = ["GLM-5.2", "GLM-5.3"]
#[test]
fn tilix_and_terminator_cap_redraws_without_disabling_motion() {
let _g = term_program_test_guard();
let _no_animations = crate::test_support::EnvVarGuard::remove("NO_ANIMATIONS");
// Neutralize the SSH markers: production intentionally caps motion
// over SSH, and the suite routinely runs inside one.
let _ssh_client = crate::test_support::EnvVarGuard::remove("SSH_CLIENT");
Expand Down
Loading