fix(installer): move MetalLB config under Cluster struct - #636
Draft
OliverTrautvetter wants to merge 12 commits into
Draft
fix(installer): move MetalLB config under Cluster struct#636OliverTrautvetter wants to merge 12 commits into
OliverTrautvetter wants to merge 12 commits into
Conversation
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
OliverTrautvetter
marked this pull request as ready for review
August 4, 2026 12:13
OliverTrautvetter
requested review from
joka134
and removed request for
joka134
August 4, 2026 12:13
OliverTrautvetter
marked this pull request as draft
August 5, 2026 08:02
…g/profile helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how MetalLB configuration is handled throughout the codebase, moving the
MetalLBconfiguration from the root level ofRootConfiginto the nestedClusterConfigstruct. Additionally, it introduces new Kubernetes network configuration flags and ensures proper defaulting for certificate issuer type.MetalLBconfiguration from the root ofRootConfigto be underClusterConfig, updating all code references accordingly to useconfig.Cluster.MetalLBinstead ofconfig.MetalLB--k8s-pod-cidrand--k8s-service-cidrto allow specifying Pod and Service CIDRs when not using Codesphere-managed KubernetesClickup and Clickup