Repository navigation
Rate-limit authentication routes - #240
Merged
Merged
Conversation
Apply the existing API rate-limit policy to auth endpoints so repeated login and logout requests receive the standard throttling response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The authentication router was not mounted below the existing API-wide limiter. Repeated authentication requests were therefore not throttled by the application policy.
User impact
Normal sign-in and logout continue to work within the existing 300 requests per 15-minute IP window. Excessive requests receive the established rate_limited response. No email-related behavior is added or changed.
Validation
Closes #239.