Skip to content

docs(provider/env): clarify merge_strategy does not include host environment - #538

Merged
bpmct merged 2 commits into
mainfrom
bpmct/docs-env-merge-host
Aug 24, 2026
Merged

docs(provider/env): clarify merge_strategy does not include host environment#538
bpmct merged 2 commits into
mainfrom
bpmct/docs-env-merge-host

Conversation

@bpmct

@bpmct bpmct commented Aug 24, 2026

Copy link
Copy Markdown
Member

The merge_strategy schema description for coder_env only explained how values merge across coder_env resources. It never mentioned that this excludes any value already present in the workspace's environment, such as a base image's PATH. A user hit this in coder/coder#27501: appending to PATH across three coder_env resources replaced the host's PATH entirely.

Update the schema description and the coder_env example to show referencing $PATH in one resource so the host's original value is kept. Ran make gen to regenerate docs/resources/env.md.

Refs coder/coder#27501


Opened by Coder Agents on behalf of @bpmct.

@bpmct
bpmct marked this pull request as ready for review August 24, 2026 11:40

@nickvigilante nickvigilante left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit with a few tweaks for clarity and a deliberate sublist for each of the possible values, but LGTM! :shipit: 🚀

@bpmct
bpmct merged commit 91c5b76 into main Aug 24, 2026
7 checks passed
@bpmct
bpmct deleted the bpmct/docs-env-merge-host branch August 24, 2026 12:33
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants