test: pin parameter, preset and tag values that flow from resources - #223
Draft
Emyrk wants to merge 1 commit into
Draft
test: pin parameter, preset and tag values that flow from resources#223Emyrk wants to merge 1 commit into
Emyrk wants to merge 1 commit into
Conversation
Baseline vectors for any evaluation strategy that skips resource blocks (coder/trivy#74, #221). Covers direct, local, indexed, transitive, conditional, try(), nested option and dynamic blocks, meta-arguments, data-source intermediaries, module inputs, and a JSON template with two resources in one expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the parameter, preset, and tag values that flow from
resourceblocks, ahead of #221 (which evaluates only the parameter/preset/tag closure via coder/trivy#74). Everything passes onmain, where nothing is pruned, so a failure after rebasing #221 means pruning dropped a resource a target depends on.testdata/resourceclosure: the fixture from feat: evaluate only the parameter/preset/tag closure when rendering #221 plus conditional,try(), expression index,optionanddynamic "option"blocks,counton a target, a data-source intermediary, tag -> resource -> parameter, presetprebuilds, and a local module.testdata/resourceclosurejson: a.tf.jsontemplate with two resources in one expression. This currently fails against the feat: evaluate only the parameter/preset/tag closure when rendering #221 pin (second resource pruned, default unknown); see the comment on coder/trivy#74.Prepared with Coder Agents assistance.