Repository navigation
Release v0.1.0-beta.3 - #47
Conversation
_Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: I021f79b32f2433d3d9bfa1abde9f6bf3bf341bad Signed-off-by: Thomas Kosiewski <tk@coder.com>
_Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: Idc6f2b658f92fa2289c12ac0775ee57173708d9c Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d5f94ba7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
FAIL Independent release verify of #47. I did not write this PR or #46. Why FAIL. The CHANGELOG at the head breaks the v0.1.0-beta.2 section. The bot commit SHAs
Checks
Crash repro (public API,
|
| Case | 0.1.0-beta.2 (npm) | 0.1.0-beta.3 (packed head) |
|---|---|---|
| control (no trap, styled cells) | exit 0, returned | exit 0, returned |
Object.prototype.includeCells getter, snapshot() |
SIGABRT, terminal.cc:577 BuildSnapshot: Assertion 'terminal_ != nullptr' |
exit 0, threw GhosttyVtTerminal has been disposed |
Object.prototype.includeScrollback getter, snapshot() |
SIGABRT, same assertion | exit 0, threw GhosttyVtTerminal has been disposed |
row setter, plain screen, snapshot() |
SIGABRT, terminal.cc:650 ReadLine: Assertion 'terminal_ != nullptr' |
exit 0, returned, setter ran 0 times |
text setter, styled cells, includeCells |
SIGSEGV | exit 0, returned, setter ran 0 times |
row setter, styled cells, includeCells |
SIGSEGV | exit 0, returned, setter ran 0 times |
row setter, plain cells, includeCells |
exit 0, threw ghostty_terminal_grid_ref failed: GHOSTTY_INVALID_VALUE |
exit 0, returned, setter ran 0 times |
Array.prototype[0] setter, snapshot() |
SIGABRT, ReadLine assertion | exit 0, returned, setter ran 0 times |
Required fix
In CHANGELOG.md, replace this line:
- Documentation no longer lists macOS x64 as a published prebuild target ([#4](https://github.com/coder/libghostty-vt-node/pull/4)).## Fixed
with these three lines (main's text):
- Documentation no longer lists macOS x64 as a published prebuild target ([#4](https://github.com/coder/libghostty-vt-node/pull/4)).
## Fixed
After the fix, git diff origin/main -- CHANGELOG.md adds lines only. The fix commit stays in place: the release-changelog job skips regeneration because the entry exists (check 4).
Notes
- Optional wording fix, not a FAIL. The entry says a
row/textsetter "segfaulted Node". The repro shows a segfault only with styled cells andincludeCells. A plainsnapshot()aborts on an assertion, and plain cells throw. The entry also quotes the error as"disposed", but the message isGhosttyVtTerminal has been disposed. Suggested last two sentences of the bullet:so a getter that disposes the terminal during that read throws "GhosttyVtTerminal has been disposed". Before, such a setter (for example on `row` or `text`) crashed Node with a segfault or an assertion abort, and such a getter aborted it on an assertion ([#46](https://github.com/coder/libghostty-vt-node/pull/46) by @ThomasK33). - The GitHub release notes come from a separate Communique run in
publish.yml. Nobody can review them before merge, but you can edit them after publish. - I verified linux-x64 only. The publish workflow builds linux-arm64 and darwin-arm64.
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high
Change-Id: Ibcc80d00b6c4ab91748a858fdeb7aa79ace8df7a Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
Fixed in da96287: restored the blank line before beta.2's |
|
@codex review |
|
@codex security review |
|
PASS Re-verify of #47 at head SHAs
Checks
Carried over from
|
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Why
Ship the
snapshot()crash fix (#46) to npm. Every earlier version,0.1.0-beta.2included, crashes Node when a JS accessor onObject.prototypedisposes the terminal whilesnapshot()builds its result.What changed
package.jsonandpackage-lock.jsongo from0.1.0-beta.2to0.1.0-beta.3. The branch name matches the version, sopublish.ymlcreatesv0.1.0-beta.3after merge.release-changelogworkflow adds the CHANGELOG entry to this branch.Blast Radius
The merge publishes
0.1.0-beta.3to npm under thebetadist-tag.lateststays on0.1.0-beta.0. Snapshot output is byte-identical to beta.2, as #46's verifier checked.Verification
prepare-release-changelog.mjsprintsshould_generate=trueandversion-changed.resolve-npm-publish-tag.mjsprintsbeta.9f8ec06with Node 26.12.1:npm test(77 passed),build:prebuild,verify:prebuilds(loadsprebuilds/linux-x64) andnpm pack --dry-runall pass.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high