Skip to content

getNativeInfo() does not report the pinned Ghostty version or commit #45

Closed

Description

@ThomasK33

getNativeInfo() cannot tell consumers which Ghostty the addon was built from. On main (83d79f7, Ghostty v1.4.0) and on the previous pin it returns ghosttyVersion: "0.1.0-dev" and no ghosttyCommit.

  • ghosttyVersion comes from GHOSTTY_BUILD_INFO_VERSION_STRING, which reports libghostty-vt's own library version (lib_version = "0.1.0-dev" in Ghostty's build.zig), not the Ghostty release.
  • ghosttyCommit comes from GHOSTTY_BUILD_INFO_VERSION_BUILD, which Ghostty leaves empty for the lib artifact, so the binding omits it.
  • .agents/skills/verify-libghostty-vt-node/features/native-info.md already documents this.

The build script already knows the pinned commit (GHOSTTY_COMMIT) and writes ghostty-source.json next to the library. One option is to compile that commit into the addon, or to report it from the package, so getNativeInfo() can name the Ghostty version consumers run.

Found during the readiness review of #43.

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high

Activity

  1. self-assigned this
    on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions