You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
port proxy via domain conflicts with code server #1804
if i use the subdomain proxy approach with my external name i get an error. my server is at `code.foo.local and domain to foo.local. i get the error below:
must the domain be a child as 1234.code.foo.local?
Oof, something unfortunate seems to have happened to the CSS, we'll have to look into that.
Yeah if you have --proxy-domain foo.local then it will try to proxy *.foo.local which includes code.foo.local.
That means you'll need to use --proxy-domain code.foo.local and browse to <port>.code.foo.local like you've noted, or use some other domain for the proxying if that feels too long.
The proxy feature uses the host header, so you could also set the host to foo.local when the domain is code.foo.local, then code-server won't proxy because it'll think it's on foo.local.
We should add a check to make sure the subdomain is a number before proxying to better support a same-level scenario like this.
Activity
nhooyr commentedon Jun 13, 2020
Should just work. cc @code-asher
code-asher commentedon Jun 13, 2020
Oof, something unfortunate seems to have happened to the CSS, we'll have to look into that.
Yeah if you have
--proxy-domain foo.localthen it will try to proxy*.foo.localwhich includescode.foo.local.That means you'll need to use
--proxy-domain code.foo.localand browse to<port>.code.foo.locallike you've noted, or use some other domain for the proxying if that feels too long.The proxy feature uses the host header, so you could also set the host to
foo.localwhen the domain iscode.foo.local, then code-server won't proxy because it'll think it's onfoo.local.We should add a check to make sure the subdomain is a number before proxying to better support a same-level scenario like this.
code-asher commentedon Jun 13, 2020
Oh right the CSS won't load because all the CSS requests will be having the same "not a valid number" error. So nevermind on that.