Add use-modern-go agent skill from JetBrains/go-modern-guidelines - #60
Conversation
Installed via the skills CLI (npx skills add JetBrains/go-modern-guidelines -s use-modern-go), which generated the skills-lock.json entry. Verified locally: run-tool.sh list resolves go 1.26 from go.mod and returns the guideline set; explain works.
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ac9417817
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
A bare single-quoted path in PowerShell is a string literal, not a command; prefix the call operator (&) so the documented invocation actually runs the wrapper. One-line local deviation from upstream, reported at JetBrains/go-modern-guidelines#25; drift disappears at the next skills update once upstream merges the fix.
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Installs the JetBrains
use-modern-goagent skill into.agents/skills/use-modern-go/, following the repo's existing skill-management convention.What's in the diff
.agents/skills/use-modern-go/— SKILL.md +scripts/run-tool.{sh,ps1}+scripts/VERSION(pins CLIv0.1.1), copied verbatim from upstreamplugin/skills/use-modern-go/.skills-lock.json— entry generated by theskillsCLI (npx skills add JetBrains/go-modern-guidelines -s use-modern-go -y), same tool that produced the existingmattpocock/skillsentries, socomputedHashfollows the CLI's own convention.AGENTS.md— one-line "Modern Go" subsection pointing agents at the skill, matching the existing section style.Verification (local)
go installsgithub.com/JetBrains/go-modern-guidelines@v0.1.1into~/.cache/go-modern-guidelines/v0.1.1/(repo pins go 1.26.3; install and run worked with the mise-managed go 1.26.5 toolchain).listresolved the target Go version fromgo.modand returned 48 guidelines applicable up to go 1.26 (newest first:new_expression,errors_as_type,sync_waitgroup_go, … down totime_since).explain min_max(smoke test) returned the detailed guideline with before/after examples.--versionreportsv0.1.1, matchingscripts/VERSION.Follow-up PR will run a guided modernization pass over the Go modules using this skill.
Generated with
mux• Model:anthropic:claude-fable-5• Thinking:xhigh