Skip to content

fix: Writing HTTP methods in uppercase - #1409

Open
neznaika0 wants to merge 3 commits into
codeigniter4:developfrom
neznaika0:fix/clear-error-log
Open

neznaika0 wants to merge 3 commits into
codeigniter4:developfrom
neznaika0:fix/clear-error-log

Conversation

@neznaika0

@neznaika0 neznaika0 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • The deprecated HTTP methods calls have been replaced: 'get' >> 'GET'

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn

Copy link
Copy Markdown
Member

Our composer.json still allows CodeIgniter versions earlier than 4.5, so we can't rely on Method::GET yet.

@neznaika0

neznaika0 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

I guess we're leaning towards the latest versions because of security, no?
We don't even have tests for this version.

@michalsn

Copy link
Copy Markdown
Member

We haven't decided when to do that yet, and I’d lean towards a major release.
But the next planned version is 1.5.

@neznaika0

Copy link
Copy Markdown
Contributor Author

I'll change the constants to strings.

@neznaika0 neznaika0 changed the title fix: Writing HTTP methods fix: Writing HTTP methods in uppercase Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants