Skip to content

refactor: cleanup psalm and raise to errorLevel 6 - #1407

Open
paulbalandan wants to merge 1 commit into
codeigniter4:developfrom
paulbalandan:cleanup-psalm
Open

paulbalandan wants to merge 1 commit into
codeigniter4:developfrom
paulbalandan:cleanup-psalm

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
Clean up the Psalm tooling.

  • Previous errors in baseline were fixed, so removed.
  • Raised errorLevel to 6 (from 7) and fixed the actionable errors and baselined the others.
  • findUnusedBaselineEntry: true keeps the baseline tidy, by reporting stale errors.
  • GHA workflow paths entry is scoped to what matters to psalm

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Comment thread src/Entities/Group.php
* Represents a single User Group
* and provides utility functions.
*
* @property string $alias

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven’t studied everything yet. Can this property be made real in the class? I see that it isn’t saved and is virtual for some tasks.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants