Skip to content

test: fix identity type assertion in email activation test - #1392

Merged
datamweb merged 1 commit into
codeigniter4:developfrom
datamweb:test/fix-email-activation-identity-assertion
Nov 9, 2026
Merged

datamweb merged 1 commit into
codeigniter4:developfrom
datamweb:test/fix-email-activation-identity-assertion

Conversation

@datamweb

@datamweb datamweb commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Description
The test currently checks for the removal of an EMAIL_2FA identity, whereas the tested functionality is email activation and should verify the removal of the EMAIL_ACTIVATE identity.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb
datamweb force-pushed the test/fix-email-activation-identity-assertion branch from be4d90b to 146bd20 Compare November 6, 2026 09:24
@datamweb datamweb added the testing Pull requests that changes tests only label Nov 6, 2026
@datamweb
datamweb force-pushed the test/fix-email-activation-identity-assertion branch from 146bd20 to 5f1791c Compare November 8, 2026 08:23
@datamweb
datamweb force-pushed the test/fix-email-activation-identity-assertion branch from 5f1791c to e6c9c00 Compare November 8, 2026 10:22
@datamweb
datamweb merged commit c990c3a into codeigniter4:develop Nov 9, 2026
35 of 36 checks passed
@datamweb
datamweb deleted the test/fix-email-activation-identity-assertion branch November 9, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants