Skip to content

chore: fix the composer normalize check and remove PhpMetrics - #10640

Merged
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:fix-composer-normalize-check
Oct 19, 2026
Merged

paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:fix-composer-normalize-check

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
The composer normalize check has been a silent no-op since #9047 moved the plugin into utils. Each step logs Command "normalize" is not defined., but echo "$(composer normalize)" always exits 0.

  • Move the check to its own workflow. It runs only when a composer.json changes.
  • Run the plugin from utils with --dry-run, which fails on an unnormalized file. Also check utils/composer.json.
  • Remove PhpMetrics. It is unused in CI, undocumented, and pinned to a release candidate.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@carson-codeigniter4 carson-codeigniter4 Bot added the github_actions Pull requests that update Github_actions code label Oct 18, 2026
@paulbalandan
paulbalandan merged commit b74fff9 into codeigniter4:develop Oct 19, 2026
52 checks passed
@paulbalandan
paulbalandan deleted the fix-composer-normalize-check branch October 19, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants