chore: fix phpstan notice on latest 2.2.15 - #10584
Merged
samsonasik merged 3 commits intoSep 25, 2026
Merged
Conversation
Member
Author
|
Ready for review 👍 |
Member
Author
|
I've fixed by patch in the on purpose test, no need baseline generation. Ready for review 👍 |
paulbalandan
approved these changes
Sep 25, 2026
paulbalandan
left a comment
paulbalandan
left a comment
Member
There was a problem hiding this comment.
I'm curious why the need to assign to a local variable first? Otherwise, this looks good.
Member
Author
|
@paulbalandan latest phpstan on direct assert same with scalar values somehow cause always true notice |
Member
Author
|
@paulbalandan thank you for the review, let's merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Latest phpstan 2.2.15 cause notice https://github.com/codeigniter4/CodeIgniter4/actions/runs/35972826580/job/107546273341
This PR bump to phpstan ^2.2.15 and try to fix it.
Checklist: