Skip to content

fix: throw Postgre query errors with warnings disabled (#6913) #10573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wakqasahmed wants to merge 2 commits into
base: develop
Choose a base branch
from
+25 −1
Open

fix: throw Postgre query errors with warnings disabled (#6913) #10573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5504162
fix: throw Postgre query errors with warnings disabled (#6913)
wakqasahmed Sep 19, 2026
6d7297a
style: satisfy Rector for Postgre errors (#6913)
wakqasahmed Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion system/Database/Postgre/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,13 @@ public function getVersion(): string
protected function execute(string $sql)
{
try {
return pg_query($this->connID, $sql);
$result = pg_query($this->connID, $sql);

if ($result === false && $this->DBDebug) {
throw new DatabaseException(pg_last_error($this->connID));
}

return $result;
} catch (ErrorException $e) {
$trace = array_slice($e->getTrace(), 2); // remove the call to error handler

Expand Down
18 changes: 18 additions & 0 deletions tests/system/Database/Live/BadQueryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,22 @@ public function testBadQueryDebugFalse(): void

$this->enableDBDebug();
}

public function testPostgreBadQueryDebugTrueWithWarningsDisabled(): void
{
if ($this->db->DBDriver !== 'Postgre') {
$this->markTestSkipped('This test is only for Postgre.');
}

$this->enableDBDebug();
$errorReporting = error_reporting(E_ALL & ~E_WARNING);

try {
$this->expectException(DatabaseException::class);
$this->expectExceptionMessage('table_does_not_exist');
$this->db->query('SELECT * FROM table_does_not_exist');
} finally {
error_reporting($errorReporting);
}
}
}
Loading