Choose the versioned module descriptor by the target release - #240
Merged
Merged
Conversation
AbstractBinaryModuleInfoParser and LocationManager.resolvePath picked the versioned module-info.class of a multi-release jar or output directory by counting down from the running JDK's version. Add ResolvePathsRequest. setTargetRelease(JavaVersion) so callers such as maven-compiler-plugin can pass the release the code is actually compiled for, and thread it through resolvePaths to both the jar/directory lookup and the modulepath routing check. Defaults to the running JDK, so behaviour is unchanged unless a caller sets it. Fixes #237
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
setTargetRelease(JavaVersion)toResolvePathsRequestandResolvePathRequest, so callers such as maven-compiler-plugin and maven-javadoc-plugin pickMETA-INF/versions/<N>/module-info.classby their--release/-targetrather than by the JDK running Maven. The default stays the running JDK, so callers that do not set it see no change.Closes #237