Use shared workflows for change detection, prek, and gate job#2104
Merged
Use shared workflows for change detection, prek, and gate job#2104
Conversation
Replace inline determine-changes, prek, and required-checks-passed jobs with reusable workflows and composite actions from codeflash-ai/github-workflows. This reduces CI maintenance burden by centralizing common CI logic.
github-actions
Bot
added
the
workflow-modified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #2044
Summary
determine-changes: Replace inline shell-based change detection (merge-base +check_paths()) withcodeflash-ai/github-workflows/.github/workflows/determine-changes.yml@mainreusable workflow. All downstream jobs now read flags viafromJSON(needs.determine-changes.outputs.flags).FLAG_NAMEinstead of direct output references.prek: Replace inline ruff auto-fix + prek-action steps withcodeflash-ai/github-workflows/.github/workflows/prek-lint.yml@mainreusable workflow, passingauto-fix,checkout-ref, andrestore-pathsinputs.required-checks-passed: Replace inline jq verification script withcodeflash-ai/github-workflows/.github/actions/required-checks-gate@maincomposite action.All other jobs (check-linked-issue, unit-tests, coverage, type-check, e2e-python, e2e-js, e2e-java) are unchanged beyond the
if:condition updates for the new output format.Test plan
determine-changescorrectly detects this PR touches.github/workflows/ci.yamland sets appropriate flagsprekjob runs and applies auto-fix if neededrequired-checks-passedgate job correctly aggregates all upstream results