Repository navigation
[Bug] Escape does not close the sidebar #81
Description
Quoted from @DawidGardzinski in the original issue Feedback after 1-2 weeks of using Libris (#78).
This only happens immediately after opening it. After clicking inside the window again, it works correctly.
Author: @DawidGardzinski
Original issue: #78
Activity
codebude commentedon Sep 4, 2026
Honestly, Escape doesn't close the sidebar for me at all – not even when I click to move the focus onto the sidebar first. I suspect that's because I've disabled the "close on backdrop click" behavior. (That was intentional, so you don't lose your changes if you accidentally click next to the sidebar.) Closing via the Esc key should of course still work. I'll look into it and build a fix.
@DawidGardzinski Just adding you here so you see my reply – looking forward to your take on this.
DawidGardzinski commentedon Sep 5, 2026
Okay, in my case it works like this: I click a book → the sidebar opens → I press Escape → nothing happens.
But if I click a book → the sidebar opens → I click on the dimmed background → I press Escape → the sidebar closes.
codebude commentedon Sep 7, 2026
Ok, I can reproduce it now. That's not the wanted behaviour. Esc should work regardless of the focused element. I'll fix it.
codebude commentedon Sep 8, 2026
Hi @DawidGardzinski I implemented the close on esc functionalty in #96 whihc is merged to develop branch now. Feel free to test and leave feedback if you think it needs more work.