Repository navigation
feat(solid): migrate adapter to Solid 2 - #40
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Solid adapter now targets Solid 2.0.0-rc.18 exclusively. Its public snapshot-accessor API stays the same, while synchronous notifications let Solid's own scheduler and
flush()observe store updates correctly. Ordinary core subscriptions remain batched.Require a live Solid owner before subscribing and stop delivery when that owner is disposed, including disposal during notification. Migrate the example and compiler tooling, add real browser regressions, and document the Solid 1 removal in a minor changeset for 0.9.0.
Validation:
Upgrade: pin
solid-jsto2.0.0-rc.18; browser apps should also pin@solidjs/webto that version and use Solid 2 compiler tooling. CalluseClassyStore()inside a component or livecreateRoot(). Solid 1 is no longer supported.