added saveguards for the std::number::log function#182
Merged
raphael-goetz merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/taurus/-/pipelines/2479530785 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14089183180/artifacts/out/index.html |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds runtime-domain safeguards to std::number::log to prevent returning NaN/∞ and instead surface explicit InvalidArgumentRuntimeError failures, addressing issue #180.
Changes:
- Added finiteness and domain checks for
valueandbaseinstd::number::log, returningT-STD-00001failures on invalid inputs. - Added unit tests to verify
logfails for negative input and invalid bases (0 and 1).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #180