Skip to content

return definition service success #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphael-goetz merged 4 commits into from
Apr 15, 2026
Merged

return definition service success #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3f9a0a
feat: update service will return success
raphael-goetz Apr 15, 2026
f586a7b
ref: cargo fmt
raphael-goetz Apr 15, 2026
091b35a
fix: all bools must be true
raphael-goetz Apr 15, 2026
868c3ca
Update src/flow_service/mod.rs
raphael-goetz Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/flow_definition/feature/version.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ pub trait HasVersion {
fn version(&self) -> &String;

fn is_accepted(&self, filter: &Option<String>) -> bool {
filter
.as_ref()
.is_none_or(|v| self.version() == v)
filter.as_ref().is_none_or(|v| self.version() == v)
}
}

Expand Down
50 changes: 34 additions & 16 deletions src/flow_service/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,21 @@ impl FlowUpdateService {
}

pub async fn send(&self) {
self.update_data_types().await;
self.update_runtime_functions().await;
self.update_functions().await;
self.update_flow_types().await;
let _ = self.send_with_status().await;
}

async fn update_data_types(&self) {
pub async fn send_with_status(&self) -> bool {
let data_types_success = self.update_data_types().await;
let runtime_functions_success = self.update_runtime_functions().await;
let functions_success = self.update_functions().await;
let flow_types_success = self.update_flow_types().await;
data_types_success && runtime_functions_success && functions_success && flow_types_success
}

async fn update_data_types(&self) -> bool {
if self.data_types.is_empty() {
log::info!("No DataTypes present.");
return;
return true;
}

log::info!("Updating {} DataTypes.", self.data_types.len());
Expand All @@ -115,21 +120,25 @@ impl FlowUpdateService {

match client.update(request).await {
Ok(response) => {
let res = response.into_inner();
log::info!(
"Was the update of the DataTypes accepted by Sagittarius? {}",
response.into_inner().success
res.success
);
Comment thread
raphael-goetz marked this conversation as resolved.

res.success
}
Err(err) => {
log::error!("Failed to update data types: {:?}", err);
false
}
}
}

async fn update_functions(&self) {
async fn update_functions(&self) -> bool {
if self.functions.is_empty() {
log::info!("No FunctionDefinitions present.");
return;
return true;
}

log::info!("Updating {} FunctionDefinitions.", self.functions.len());
Expand All @@ -144,21 +153,24 @@ impl FlowUpdateService {

match client.update(request).await {
Ok(response) => {
let res = response.into_inner();
log::info!(
"Was the update of the FunctionDefinitions accepted by Sagittarius? {}",
response.into_inner().success
res.success
);
Comment thread
raphael-goetz marked this conversation as resolved.
res.success
}
Err(err) => {
log::error!("Failed to update function definitions: {:?}", err);
false
}
}
}

async fn update_runtime_functions(&self) {
async fn update_runtime_functions(&self) -> bool {
if self.runtime_functions.is_empty() {
log::info!("No RuntimeFunctionDefinitions present.");
return;
return true;
}

log::info!(
Expand All @@ -176,21 +188,24 @@ impl FlowUpdateService {

match client.update(request).await {
Ok(response) => {
let res = response.into_inner();
log::info!(
"Was the update of the RuntimeFunctionDefinitions accepted by Sagittarius? {}",
response.into_inner().success
res.success
);
Comment thread
raphael-goetz marked this conversation as resolved.
res.success
}
Err(err) => {
log::error!("Failed to update runtime function definitions: {:?}", err);
false
}
}
}

async fn update_flow_types(&self) {
async fn update_flow_types(&self) -> bool {
if self.flow_types.is_empty() {
log::info!("No FlowTypes present.");
return;
return true;
}

log::info!("Updating {} FlowTypes.", self.flow_types.len());
Expand All @@ -205,13 +220,16 @@ impl FlowUpdateService {

match client.update(request).await {
Ok(response) => {
let res = response.into_inner();
log::info!(
"Was the update of the FlowTypes accepted by Sagittarius? {}",
Comment thread
raphael-goetz marked this conversation as resolved.
response.into_inner().success
res.success
);
res.success
}
Err(err) => {
log::error!("Failed to update flow types: {:?}", err);
false
}
}
}
Expand Down