Skip to content

Expose more fields in OperatingSystemStatus - #199

Merged
toanju merged 1 commit into
mainfrom
add-commit-sha
Dec 17, 2025
Merged

Expose more fields in OperatingSystemStatus#199
toanju merged 1 commit into
mainfrom
add-commit-sha

Conversation

@toanju

@toanju toanju commented Dec 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Expose more fields in OperatingSystemStatus

Exposes the following additional fields

  • GardenLinuxCommitID
  • GardenLinuxFeatures
  • VariantID

to share more details on a Garden Linux based installation

@toanju
toanju requested review from fwiesel and notandy December 16, 2025 09:02
@fwiesel

fwiesel commented Dec 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

I see the need in it, and it is probably just bike-shedding, but this is tied to the gardenlinux build process, and doesn't cover all the inputs (i.e. GARDENLINUX_CNAME).

How about setting and using some standard fields instead?
I'd be a fan of setting BUILD_ID to ${{github.workflow}}-${{github.run_number}} or ${{github.run_id}}.

Or would VARIANT_ID and GARDENLINUX_COMMIT_ID suffice to uniquely identify the build?

fwiesel
fwiesel reviewed Dec 16, 2025
View reviewed changes

@fwiesel fwiesel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it, in case you want to move forward regardless of the alternatives proposed.
Worst-case we migrate..

@fwiesel

fwiesel commented Dec 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Small detail, I'd go a least with commitID or even gardenlinuxCommitID as that is the name in the os-release file.

@toanju

toanju commented Dec 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

we were discussing if BUILD_ID actually suites here, however BUILD_ID does not really match for Garden Linux since we do not have a particular underlying build that resides the same. Will update to commitID.

notandy
notandy requested changes Dec 16, 2025
View reviewed changes
Comment thread api/v1/hypervisor_types.go Outdated
@toanju toanju changed the title Expose commit sha of Garden Linux images Expose more fields in OperatingSystemStatus Dec 17, 2025
@toanju
toanju requested review from fwiesel and notandy December 17, 2025 08:30
@toanju

toanju commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

I agree with

would VARIANT_ID and GARDENLINUX_COMMIT_ID suffice to uniquely identify the build

and adjusted accordingly and added the Features in addition

anokfireball
anokfireball approved these changes Dec 17, 2025
View reviewed changes

@anokfireball anokfireball left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is worth it to "properly" expose the feature list? Don't feel forced to follow through with this suggestion, though!

Comment thread api/v1/hypervisor_types.go Outdated
Comment thread config/crd/bases/kvm.cloud.sap_hypervisors.yaml Outdated
Comment thread applyconfigurations/api/v1/operatingsystemstatus.go Outdated
@toanju

toanju commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

yes, I was thinking about the list, but still checking on the guarantees here

@toanju

toanju commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

list it is...

notandy
notandy requested changes Dec 17, 2025
View reviewed changes
Comment thread api/v1/hypervisor_types.go Outdated
@toanju
Expose more fields in OperatingSystemStatus
7faabc9 
Exposes the following additional fields

* GardenLinuxCommitID
* GardenLinuxFeatures
* VariantID

to share more details on a Garden Linux based installation
@github-actions

github-actions Bot commented Dec 17, 2025

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_types.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/zz_generated.deepcopy.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/operatingsystemstatus.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@toanju
toanju merged commit b801e15 into main Dec 17, 2025
6 checks passed
@fwiesel
fwiesel deleted the add-commit-sha branch July 8, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notandy notandy notandy approved these changes
@fwiesel fwiesel fwiesel approved these changes
@anokfireball anokfireball anokfireball approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@toanju @fwiesel @notandy @anokfireball