Skip to content

Onboarding: Only reset ones own readiness summary - #198

Merged
notandy merged 1 commit into
mainfrom
fix-readiness-summary
Dec 16, 2025
Merged

Onboarding: Only reset ones own readiness summary#198
notandy merged 1 commit into
mainfrom
fix-readiness-summary

Conversation

@fwiesel

@fwiesel fwiesel commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

When onboarding aborts, it means usually that another controller will take over, so we better do not remove its summary (i.e. during scaledown).

Comment thread internal/controller/onboarding_controller.go Outdated
@fwiesel
fwiesel force-pushed the fix-readiness-summary branch from 19c2bd9 to 149e929 Compare December 16, 2025 17:15
@fwiesel
fwiesel requested a review from notandy December 16, 2025 17:15
@github-actions

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 49.91% (-0.23%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller.go 55.02% (-1.13%) 249 (+5) 137 112 (+5) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

When onboarding aborts, it means usually that another controller will
take over, so we better do not remove its summary (i.e. during
scaledown).
@notandy
notandy merged commit 664282f into main Dec 16, 2025
6 checks passed
@notandy
notandy deleted the fix-readiness-summary branch December 16, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants