Traits: Only reconcile after onboarding and before decomissioning - #191
Merged
Conversation
fwiesel
force-pushed
the
traits_reconcile_lifetime
branch
from
December 3, 2025 14:04
bcacbc7 to
35f8cad
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
As with 6bb6c6 for the aggregates: Traits set by the operator may conflict with the testing, and decomissioning may make the resource-provider disappear. To avoid these controllers fighting, let's limit this controller to the actual active lifetime of the hypervisor. Unfortunately, that means we have to reconcile on every status update.
notandy
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with 6bb6c6 for the aggregates:
Traits set by the operator may conflict with the testing, and decomissioning may make the resource-provider disappear. To avoid these controllers fighting, let's limit this controller to the actual active lifetime of the hypervisor.
Unfortunately, that means we have to reconcile on every status update.