Skip to content

Add hypervisorVersion to report running hypervisor version - #54

Merged
anokfireball merged 1 commit into
mainfrom
feature/report-hypervisor-version
Feb 23, 2026
Merged

Add hypervisorVersion to report running hypervisor version#54
anokfireball merged 1 commit into
mainfrom
feature/report-hypervisor-version

Conversation

@anokfireball

Copy link
Copy Markdown
Contributor

Calls ConnectGetVersion() to get the hypervisor version (e.g., CH 50.0.0) and reports it in status.HypervisorVersion, separate from libVirtVersion.

This complements PR #53 which fixed libVirtVersion to report the actual libvirt library version using ConnectGetLibVersion().

Comment thread go.mod Outdated
@anokfireball
anokfireball force-pushed the feature/report-hypervisor-version branch from c349387 to 8d6bac3 Compare February 19, 2026 13:25
@anokfireball
anokfireball marked this pull request as ready for review February 19, 2026 13:25
Calls ConnectGetVersion() to get the hypervisor version (e.g., CH
50.0.0) and reports it in status.HypervisorVersion, separate from
libVirtVersion.

This complements PR #53 which fixed libVirtVersion to report the actual
libvirt library version using ConnectGetLibVersion().
@anokfireball
anokfireball force-pushed the feature/report-hypervisor-version branch from 8d6bac3 to 3ef3208 Compare February 23, 2026 14:32
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/kvm-node-agent/internal/libvirt 40.23% (+0.23%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/kvm-node-agent/internal/libvirt/libvirt.go 71.22% (-0.28%) 205 (+5) 146 (+3) 59 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/kvm-node-agent/internal/libvirt/libvirt_test.go

@fwiesel
fwiesel self-requested a review February 23, 2026 14:51
@anokfireball
anokfireball merged commit 6645f8a into main Feb 23, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants