feat: allows KVM-enabled deployments to opt out of critical-severity alerting - #988
Merged
Conversation
mblos
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
umswmayj
as code owners
June 29, 2026 12:42
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds a KVM Critical Alerts Gate
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mblos
enabled auto-merge (squash)
June 29, 2026 12:43
PhilippMatthes
approved these changes
Jun 29, 2026
Contributor
Test Coverage ReportTest Coverage 📊: 69.9% |
2 tasks
mblos
added a commit
that referenced
this pull request
Jun 29, 2026
## Changelog ## 2026-06-29 — [#990](#990) ### cortex v0.2.0 (sha-124ec226) Breaking changes: - FlavorGroupCapacity CRD status: removed `TotalInstances` field and replaced with `RunningInstances`, `RunningResources`, `FreeCapacity`, `ExclusivelyFreeCapacity`, `ExclusivelyFreeSlots`, `CommittedCapacityBytes`, and `SmallestFlavorName` ([#983](#983)) - Committed resource capacity metric renamed from `cortex_committed_resource_reported_capacity_gib` to `cortex_committed_resource_reported_capacity` with added `unit_size` label ([#983](#983)) Non-breaking changes: - VM usage and fair capacity split for overlapping flavor groups — capacity is now split fairly across flavor groups sharing the same hypervisors via a deterministic round-robin algorithm ([#983](#983)) - Allow KVM-enabled deployments to opt out of critical-severity alerting via `kvm.criticalAlerts` value ([#988](#988)) - Update External dependencies ([#977](#977), [#982](#982)) - Update `github.com/sapcc` ([#960](#960), [#976](#976)) - Update `github.com/sapcc/go-bits` ([#984](#984)) - Bump `github.com/opencontainers/runc` from 1.3.3 to 1.3.6 ([#973](#973)) - Update kube-prometheus-stack Docker tag to v87 ([#965](#965)) - Update postgres Dockerfile base image ([#978](#978), [#979](#979)) - Update actions/checkout action to v7 ([#961](#961)) ### cortex-nova v0.0.77 Includes updated chart cortex v0.2.0. - Add `kvm.criticalAlerts` config key to opt out of critical-severity alerting for KVM regions ([#988](#988)) ### cortex-crds v0.0.77 Includes updated chart cortex v0.2.0. ### cortex-cinder v0.0.77 Includes updated chart cortex v0.2.0. ### cortex-pods v0.0.77 Includes updated chart cortex v0.2.0. ### cortex-ironcore v0.0.77 Includes updated chart cortex v0.2.0. ### cortex-manila v0.0.77 Includes updated chart cortex v0.2.0. ### General - Update hypervisor CRD for local development ([#980](#980)) - Document InFlightReservation, domain hints, and CRS metrics ([#963](#963)) - Fix stale file paths, grace period behavior, and dead cross-reference in docs ([#962](#962)) ## Prerequisites - [ ] Merge chart-bump PR: #991 (must be merged before this PR) - [ ] Merge changelog PR: #992 (merge after this PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.