refactor(nova): remove image datasource - #1006
Merged
Merged
Conversation
SoWieMarkus
requested review from
PhilippMatthes,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
July 2, 2026 08:20
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (8)
📝 WalkthroughWalkthroughThis PR removes Glance-backed image support from the Nova datasource plugin, deleting the ChangesNova Images Removal and Type Update
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Test Coverage ReportTest Coverage 📊: 70.0% |
PhilippMatthes
approved these changes
Jul 6, 2026
mblos
approved these changes
Jul 6, 2026
This was referenced Jul 6, 2026
juliusclausnitzer
added a commit
that referenced
this pull request
Jul 6, 2026
## Changelog ### cortex v0.2.2 (sha-f4d7df89) Breaking changes: - Remove Nova image datasource — the images NovaDatasourceType is no longer available ([#1006](#1006)) Non-breaking changes: - Include host information in error logs when multicluster connection fails ([#997](#997)) - Fix Perses config for local development ([#1007](#1007)) - Update `github.com/sapcc/go-bits` ([#1005](#1005)) - Update kube-prometheus-stack Docker tag to v87.4.0 ([#998](#998)) ### cortex-shim v0.1.5 (sha-c98ddb05) Includes updated image sha-c98ddb05. ### cortex-nova v0.0.79 Includes updated charts cortex v0.2.2, cortex-postgres v0.6.8. ### cortex-cinder v0.0.79 Includes updated charts cortex v0.2.2, cortex-postgres v0.6.8. ### cortex-manila v0.0.79 Includes updated charts cortex v0.2.2, cortex-postgres v0.6.8. ### cortex-crds v0.0.79 Includes updated chart cortex v0.2.2. ### cortex-ironcore v0.0.79 Includes updated chart cortex v0.2.2. ### cortex-pods v0.0.79 Includes updated chart cortex v0.2.2. ### cortex-placement-shim v0.1.5 Includes updated chart cortex-shim v0.1.5. ## Dependencies - Bump PR: #1010 (must be merged before this PR) - Changelog PR: #1011 (merge after this PR)
SoWieMarkus
pushed a commit
that referenced
this pull request
Jul 8, 2026
## Summary - Update changelog entry to include changes merged after initial entry was created - Add breaking change: remove Nova image datasource (#1006) - Add fix: zero out RunningInstances when all VMs removed (#1017) - Update go-bits and kube-prometheus-stack version references - Update appVersion SHAs (cortex: sha-8d888397, cortex-shim: sha-c8295850) - Update release date to 2026-07-06 ## Context This PR updates the CHANGELOG.md for release PR #1009, which had several additional commits merged after the initial changelog entry was created in #1011. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: cortex-ai-agents[bot] <279748396+cortex-ai-agents[bot]@users.noreply.github.com> Co-authored-by: juliusclausnitzer <juliusclausnitzer@users.noreply.github.com>
PhilippMatthes
pushed a commit
that referenced
this pull request
Jul 21, 2026
## Summary - Update changelog entry to include changes merged after initial entry was created - Add breaking change: remove Nova image datasource (#1006) - Add fix: zero out RunningInstances when all VMs removed (#1017) - Update go-bits and kube-prometheus-stack version references - Update appVersion SHAs (cortex: sha-8d888397, cortex-shim: sha-c8295850) - Update release date to 2026-07-06 ## Context This PR updates the CHANGELOG.md for release PR #1009, which had several additional commits merged after the initial changelog entry was created in #1011. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: cortex-ai-agents[bot] <279748396+cortex-ai-agents[bot]@users.noreply.github.com> Co-authored-by: juliusclausnitzer <juliusclausnitzer@users.noreply.github.com> Signed-off-by: Philipp Matthes <p.matthes@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.