Fix FixedLocator/labels mismatch in create_heatmap for large matrices - #29
Merged
Merged
Conversation
sns.clustermap's tick locator only reliably matches the cell count once the matrix is large enough (~40+ categories); below that it happens to work. Explicitly fix the x/y tick positions to cell centers (offset by 0.5, matching clustermap's own convention) before assigning labels, so set_xticklabels/set_yticklabels always see a matching tick count. Confirmed the crash empirically with 44 and 48 structures; 21 worked fine before this fix. Also scale figsize with the number of structures and drop the per-cell numeric annotations past 50 structures: with the crash fixed, larger matrices (100+) still rendered with illegible overlapping labels and cell text, since the figure size was previously fixed regardless of matrix size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sns.clustermap's tick locator only reliably matches the cell count once the matrix is large enough (~40+ categories); below that it happens to work. Explicitly fix the x/y tick positions to cell centers (offset by 0.5, matching clustermap's own convention) before assigning labels, so set_xticklabels/set_yticklabels always see a matching tick count.
Confirmed the crash empirically with 44 and 48 structures; 21 worked fine before this fix.
Also scale figsize with the number of structures and drop the per-cell numeric annotations past 50 structures: with the crash fixed, larger matrices (100+) still rendered with illegible overlapping labels and cell text, since the figure size was previously fixed regardless of matrix size.