Validate Intel RDT fields by CDI version#319
Draft
elezar wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315.
This makes Intel RDT validation aware of the declared CDI spec version. Legacy enableCMT/enableMBM fields are accepted for specs before v1.1.0 and rejected for v1.1.0+, while v1.1.0-only fields such as enableMonitoring and schemata are rejected for older declared versions. The raw-content validation path catches false-valued fields that are otherwise indistinguishable from omitted bools after unmarshalling.
The change also restores legacy IntelRdt fields in specs-go for compatibility and maps legacy monitoring booleans to OCI EnableMonitoring when applying edits.
Tests: