Conversation
cmsj
commented
Aug 1, 2026
Owner
- Checkpoint
- Switch to using non-deprecated APIs
Contributor
Greptile SummaryAdds the new CoreMIDI-backed hs.midi module and its generated API surface.
Confidence Score: 4/5The PR is not yet safe to merge because a transient source-connection failure permanently disables input retries for that device object. The failed MIDIPortConnectSource branch still leaves inputPort nonzero and selfRef retained, while every later non-nil setCallback call is blocked by the inputPort == 0 guard and cannot reconnect. Files Needing Attention: Hammerspoon 2/Modules/hs.midi_/HSMIDIDevice.swift Important Files Changed
Reviews (2): Last reviewed commit: "Prevent SysEx messages from potentially ..." | Re-trigger Greptile |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.