Conversation
…arate part of the app bundle, with safer names
…PI that we might implement in the future
Contributor
Greptile SummaryThis PR adds a CommonJS module loader and npm bundling workflow for user scripts. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "Make json parsing safer in require.js" | Re-trigger Greptile |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE This PR exists as an alternative to #6 without having to use any JavaScriptCore internal API.
Implement a CommonJS-style module loader to replace our naive require() function. Seed a new user's config directory with a package.json and bundler to assist with importing from npm.
These are the steps a new user would take, to make use of this:
~/.config/hammerspoon2/and seedspackage.jsonandbundle.jsinto it.brew install node. This also providesnpmandnpx.bundle.js, which callsnpx esbuild(downloaded automatically on first use) and writeslib/date-fns.js.init.js:hs.reload().Steps 3–4 repeat whenever a new package is added or an existing one is updated. Step 4 is also needed after npm update since it regenerates the bundles from the updated packages.