Restructure ImageExtractor for better import in blocking context#187
Open
mirkoDeer wants to merge 28 commits into
Open
Restructure ImageExtractor for better import in blocking context#187mirkoDeer wants to merge 28 commits into
mirkoDeer wants to merge 28 commits into
Conversation
mirkoDeer
changed the title
Contributor
Author
|
ImageExtractor could be cleaner if we only had to provide one extracting logic for internal and external api. This could be achieved by providing upload with just the Path instead of the Stream, since we have to scan the directory at least twice for max efficiency (without extracting blobs in local directory for uploading) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.