feat(rpc): expose the ride-cancel auto-release window in get_chain_info - #13
Merged
Merged
Conversation
ride_auto_release_secs is genesis-committed and decides who receives money -- past the window a RideCancel pays the driver rather than refunding the passenger -- and it was not observable from outside the node. An operator could not confirm which value a chain runs without reading the node's config file on the host, which is the config rather than the committed state; and a client could not tell a rider how long a cancel still refunds them. Not adding mint_cosigners or mint_threshold in the same change: those are security-relevant and worth deciding on their own merits. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ride_auto_release_secsis a genesis-committed consensus parameter that decides who receives money — past the window aRideCancelpays the driver rather than refunding the passenger — and it was not observable from outside the node.Two consequences, both real:
get_chain_infoalready carrieschain_id,tx_fee, both referrer rates andmint_authority; this belongs with them.0means the chain does not auto-release at all, which is the default and is what every chain before today ran.Deliberately not adding
mint_cosignersormint_thresholdin the same change — those are security-relevant and worth deciding on their own merits rather than being carried along.🤖 Generated with Claude Code