Repository navigation
Parse Wilton's times written with a colon - #757
Merged
Merged
Conversation
Some Wilton's times use a colon ("2:30 pm") rather than a dot ("7.30
pm"), which the time format rejected, failing the transform.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PPQC7pUHLSSD6ayU5cZiBQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #756. With the year now parsed, the
wiltons.org.uktransform failed on the next row:Wilton's writes most times as
7 pmor7.30 pm, but some use a colon (2:30 pm). The time format only knew the dot, so the colon is now normalised to a dot before parsing.Verification
data-retrievedrelease (20261007.191751): all 9 films and 10 performances parse. Every format in that data is covered: dates with and without a year, and times asN pmandN:NN pm.npm test -- cinemas/wiltons.org.ukand lint pass. The recording has no year or colon rows, so its snapshot is unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01PPQC7pUHLSSD6ayU5cZiBQ
Generated by Claude Code