Repository navigation
Support filtering multi-film events by included films' credits - #145
Merged
Merged
Conversation
…reen A double bill or shorts programme matches no single film, so it carried no genres or credits of its own and never answered a genre, director or cast filter. Read an event as the union of what it screens, in the filters, the genre pages and the overlay's genre counts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0144SAfC3w2jNSBYcX6H84Po
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for filtering double bills, marathons and shorts programmes by the genres, directors and cast of the films they screen, rather than only by their own (usually empty) metadata.
Changes
New utility:
getMovieAndIncluded()insrc/utils/get-movie-and-included.ts— reads a film's own genres/directors/actors plus those of any films it screens (includedMovies). For unmatched events (those with no single matching film), drops the "Uncategorised" placeholder genre once the included films supply real genres.Filter integration: Updated
genresFilteranddirectorsFilter(people filter) to usegetMovieAndIncluded()when checking for matches, so a double bill matches a Horror filter if any of its films are horror.Genre pages & overlay: Updated
getGenreMovies()andGenreFilterSectionto count included films' genres when determining which films belong to a genre and how many screenings each genre has.Documentation: Added "Multi-film Events" section to CLAUDE.md explaining the design.
Tests: Comprehensive test suite covering unmatched events, placeholder genre handling, and filter matching across included films.
Implementation Details
Setto deduplicate IDs across included films and avoid allocating new arrays when unnecessary (returns the movie's own array untouched if there's nothing to add).https://claude.ai/code/session_0144SAfC3w2jNSBYcX6H84Po