Skip to content

feat(ENG-15434): Add skills upstream command - #575

Merged
pmcguckin-cloudsmith merged 5 commits into
masterfrom
pmcguckin-cloudsmith/ENG-15434/add-skills-upstream-command
Nov 4, 2026
Merged

pmcguckin-cloudsmith merged 5 commits into
masterfrom
pmcguckin-cloudsmith/ENG-15434/add-skills-upstream-command

Conversation

@pmcguckin-cloudsmith

@pmcguckin-cloudsmith pmcguckin-cloudsmith commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Description

Added support for ENG-15434

depends on:

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Other (please describe)

Additional Notes

image image image image

Copilot AI balanced review requested due to automatic review settings October 30, 2026 14:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Registering skills without adding a matching URL to the test mapping breaks the upstream key-set assertion and causes the parametrized integration test to raise KeyError: 'skills' before exercising the new commands.

1 open issue
What changed in this PR

Adds cloudsmith upstream skills to the CLI’s existing upstream-management commands for ENG-15434.

Changes:

  • Registers skills for upstream list, create, update, and delete commands.
  • Raises the minimum cloudsmith-api version to 2.0.42 and updates the lockfile.
File Description
uv.lock Pins cloudsmith-api 2.0.42 and updates package metadata.
pyproject.toml Requires cloudsmith-api>=2.0.42,<3.0.
cloudsmith_cli/​cli/​commands/​upstream.py Adds skills to the supported upstream formats.

Review effort: Balanced

Comment thread cloudsmith_cli/cli/commands/upstream.py Resolved
@pmcguckin-cloudsmith
pmcguckin-cloudsmith force-pushed the pmcguckin-cloudsmith/ENG-15434/add-skills-upstream-command branch 3 times, most recently from 422a90a to 46c9061 Compare October 30, 2026 15:37
@pmcguckin-cloudsmith
pmcguckin-cloudsmith force-pushed the pmcguckin-cloudsmith/ENG-15434/add-skills-upstream-command branch 2 times, most recently from 3ba4971 to d3ae402 Compare November 2, 2026 13:17
@pmcguckin-cloudsmith

Copy link
Copy Markdown
Contributor Author

@pmcguckin-cloudsmith
pmcguckin-cloudsmith force-pushed the pmcguckin-cloudsmith/ENG-15434/add-skills-upstream-command branch from b981bb5 to d26c3d6 Compare November 4, 2026 15:09
@pmcguckin-cloudsmith
pmcguckin-cloudsmith merged commit 828de09 into master Nov 4, 2026
25 checks passed
@pmcguckin-cloudsmith
pmcguckin-cloudsmith deleted the pmcguckin-cloudsmith/ENG-15434/add-skills-upstream-command branch November 4, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants