Repository navigation
Add GitHub Actions workflow for plugin release - #79
cthtrifork wants to merge 7 commits into
Conversation
a547f5b to
6c13eb3
Compare
leonardoce
left a comment
leonardoce
left a comment
There was a problem hiding this comment.
I think this is in a good shape. I added a few comments. Also, we could add improve our README.md file illustrating how this image should be used.
| - name: Checkout main | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 #v7.0.1 | ||
| with: | ||
| ref: main |
There was a problem hiding this comment.
We can't hard-code ref: main here. On the manual path we may have been dispatched against a specific version, and on the automatic path we may be releasing a tagged version.
In those cases main could have diverged, so building from main but tagging as vX.Y.Z would be wrong. Do you agree?
There was a problem hiding this comment.
Ah I was confused about this part. It was done as I copied the workflow from the normal plugin release which also checkouts main:
https://github.com/cloudnative-pg/cnpg-headlamp-plugin/blob/main/.github/workflows/release-plugin.yaml#L32
| inputs: | ||
| version: | ||
| description: "The plugin version (without a v prefix e.g., 0.1.0) - if not provided, will use version from package.json" | ||
| required: false |
There was a problem hiding this comment.
I believe having version as optional is fragile: when empty we read package.json, which may not match the real release version.
What about making it required: true for workflow_dispatch and using github.event.release.tag_name for the release path, dropping the package.json fallback entirely?
Also, I believe it would be best for us to have the same UX as the workflow in release-plugin.yaml. That would be a required tag parameter.
75d56da to
0c2871a
Compare
|
@leonardoce Thanks for the feedback. I am slightly confused about the release UX in the existing workflow, but I agree we should align them |
d181fc2 to
7de6b81
Compare
Signed-off-by: Casper Thygesen <cth@trifork.com>
Signed-off-by: Casper Thygesen <cth@trifork.com>
Signed-off-by: Casper Thygesen <cth@trifork.com>
…rkflow Signed-off-by: Casper Thygesen <cth@trifork.com>
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [cronstrue](https://redirect.github.com/bradymholt/cronstrue) ([source](https://redirect.github.com/bradymholt/cRonstrue)) | [`3.31.0` → `3.32.0`](https://renovatebot.com/diffs/npm/cronstrue/3.31.0/3.32.0) |  |  | --- ### Release Notes <details> <summary>bradymholt/cRonstrue (cronstrue)</summary> ### [`v3.32.0`](https://redirect.github.com/bradymholt/cRonstrue/releases/tag/v3.32.0) [Compare Source](https://redirect.github.com/bradymholt/cRonstrue/compare/v3.31.0...v3.32.0) #### What's Changed - Bump handlebars from 4.7.9 to 4.7.10 by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​424](https://redirect.github.com/bradymholt/cRonstrue/pull/424) **Full Changelog**: <bradymholt/cRonstrue@v3.31.0...v3.32.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/cloudnative-pg/cnpg-headlamp-plugin). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzQuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjEzNC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Casper Thygesen <cth@trifork.com>
…plugin Signed-off-by: Casper Thygesen <cth@trifork.com>
be6c685 to
0b021e1
Compare
2 participants
Implement a GitHub Actions workflow to automate the build and publishing of the plugin container image.
Logs from successful run in fork:
logs_99858471065.zip