Skip to content

fix(plugin-barman-cloud): add podAnnotations in deployment template - #787

Open
octane100 wants to merge 4 commits into
cloudnative-pg:mainfrom
octane100:fix/786
Open

octane100 wants to merge 4 commits into
cloudnative-pg:mainfrom
octane100:fix/786

Conversation

@octane100

@octane100 octane100 commented Jan 20, 2026 •

Copy link
Copy Markdown

This PR fixes support for adding annotations on barman plugin by setting podAnnotations in values.yaml file (documented but not implemented).

Closes #786

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jan 20, 2026
@octane100
octane100 force-pushed the fix/786 branch 5 times, most recently from 9eceba6 to 999562e Compare January 20, 2026 15:04
Comment thread charts/plugin-barman-cloud/templates/deployment.yaml Outdated
@NiccoloFei NiccoloFei added the chart( plugin-barman-cloud ) Related to the plugin-barman-cloud chart label Jul 13, 2026
@itzhak-alayev-groundcover

Copy link
Copy Markdown

I think it would be a good idea to add tpl support for podAnnotations.

@octane100

Copy link
Copy Markdown
Author

@itzhak-alayev-groundcover Thanks for the suggestion, I have updated the PR.

…mplate (cloudnative-pg#786)

Signed-off-by: octane100 <2571361+octane100@users.noreply.github.com>
@fcanovai
fcanovai requested a review from a team as a code owner October 6, 2026 15:13
@danishk

danishk commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Hi @octane100 Can you update the pr title and description. Add little bit details and use closes # with issue number in the details.

@octane100 octane100 changed the title fix(plugin-barman-cloud): add missing podAnnotations in deployment te… fix(plugin-barman-cloud): add podAnnotations in deployment template Oct 6, 2026
@octane100

Copy link
Copy Markdown
Author

Hi @octane100 Can you update the pr title and description. Add little bit details and use closes # with issue number in the details.

Done. Is it ok for you ?

Signed-off-by: Danish <danish.khan@enterprisedb.com>
@danishk

danishk commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Hi @octane100 I have added the test in this pr based on your branch. Have a look octane100#1. Once you approve you can merge the changes in this pr. I have tested it here danishk#6.
Thanks

test(plugin-barman-cloud): add podAnnotaion test

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chart( plugin-barman-cloud ) Related to the plugin-barman-cloud chart size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[plugin-barman-cloud] podAnnotations not implemented

5 participants