Skip to content

[miniflare] Fix dev registry test opt-in - #15050

Merged
edmundhung merged 1 commit into
mainfrom
maizatskyi/fix-dev-registry-test-opt-in
Aug 6, 2026
Merged

[miniflare] Fix dev registry test opt-in#15050
edmundhung merged 1 commit into
mainfrom
maizatskyi/fix-dev-registry-test-opt-in

Conversation

@mikea

@mikea mikea commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

The dev-registry registration default is now opt-in. Add unsafeRegisterWorker: true to the registry-churn test workers, including retained workers on configuration updates.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this corrects test fixtures for an existing option.

Note

This is a contribution from an AI agent: pi, GPT-5.6 Terra.


Open in Devin Review

@mikea
mikea requested a review from workers-devprod as a code owner August 6, 2026 00:45
@changeset-bot

changeset-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 513378f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mikea mikea added the ci:no-changeset-required Skip pull request checks for a valid changeset label Aug 6, 2026
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Aug 6, 2026
@workers-devprod
workers-devprod requested review from a team and penalosa and removed request for a team August 6, 2026 00:46
@workers-devprod

workers-devprod commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@ask-bonk

ask-bonk Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This confirms the context: #15040 "Restrict dev registry registration to user workers" made registration opt-in via unsafeRegisterWorker. The "registry churn" tests were likely added around that time but omitted the flag. This PR is a straightforward, correct test fix.

The change is minimal, correct, follows the existing conventions in the file, and there are no logic bugs, security issues, or behavioral problems. The setOptions calls correctly re-include the flag since options are fully replaced (not merged). Since it only touches test fixtures for an existing option, the lack of a changeset is also appropriate.

LGTM

github run

@pkg-pr-new

pkg-pr-new Bot commented Aug 6, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15050

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15050

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15050

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15050

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15050

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15050

miniflare

npm i https://pkg.pr.new/miniflare@15050

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15050

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15050

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15050

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15050

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@15050

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15050

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15050

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15050

wrangler

npm i https://pkg.pr.new/wrangler@15050

commit: 513378f

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 6, 2026
@edmundhung
edmundhung merged commit 1e16079 into main Aug 6, 2026
73 of 79 checks passed
@edmundhung
edmundhung deleted the maizatskyi/fix-dev-registry-test-opt-in branch August 6, 2026 12:56
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants