[wrangler] Fix modules-watch-stub injection when bundle:false (fixes … - #15032
Open
Sertug17 wants to merge 5 commits into
Open
[wrangler] Fix modules-watch-stub injection when bundle:false (fixes …#15032Sertug17 wants to merge 5 commits into
Sertug17 wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: 1af6db6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. [Click here if you're a maintainer who wants to add another changeset to this PR](https://github.com/Sertug17/workers-sdk/new/fix/modules-watch-stub-no-bundle?filename=.changeset/ripe-chicken-hide.md&value=---%0A%22wrangler%22%3A%20patch%0A---%0A%0A%5Bwrangler%5D%20Fix%20modules-watch-stub%20injection%20when%20bundle%3Afalse%20(fixes%20%E2%80%A6%0A) |
Author
|
I have read the CLA Document and I hereby sign the CLA |
workers-devprod
requested review from
a team and
edmundhung
and removed request for
a team
August 5, 2026 06:58
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14845.
When
bundle: false(e.g.no_bundle = trueinwrangler.toml, or the--no-bundleflag), esbuild does not resolve imports in injected files. Previouslymodules-watch-stub.jswas injected wheneverwatch: true, which leftimport "wrangler:modules-watch"unresolved in the output, causing workerd to crash at runtime:Uncaught Error: No such module "wrangler:modules-watch"
imported from "pages-shim.js"
Reproducible with
wrangler pages devon a Nitro project using thecloudflare-modulepreset (generatesno_bundle = truein wrangler.toml).Fix: only inject the stub when
bundle: true. When bundling is disabled, file watching is already handled by chokidar inuse-esbuild.ts, so the esbuild-internal watch stub is not needed.Checkboxes:
Tests: "Additional testing not necessary because:" → the watch stub injection path is tested via existing bundleWorker unit tests; no bundle mode is already covered by chokidar