[wrangler] add connect wrangler config section - #14995
Conversation
🦋 Changeset detectedLatest commit: 2ba31c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Looks good to me, although an option for this should also be added to the programmatic wrangler config
tcp_handlers wrangler config sectionconnect wrangler config section
d65961f to
fdfb8df
Compare
|
I think the test failures are unrelated to my changes. Could someone from the team confirm ? |
yes, they are not, CI's been quite flaky lately 😓 Feels free to ignore them 👍 |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
As I mentioned in my comment I really don't like the inclusion of "udp" here, besides that everything else looks good to me
c689ffc to
2ba31c3
Compare
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Thanks a lot for the udp removal @ThomasRubini 🙏
Looks good to me 😄
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
This PR adds a
tcp_handlersconfig section, for the upcoming inbound TCP feature on Workers. It will configure workerd TCP listeners as implemented in cloudflare/workerd#6059It would have to be set in the wrangler config like this:
{ "connect": [{ "protocol": "tcp", "port": 5432, "address": "127.0.0.1", // default }], }or in the new config format like this:
I'd love feedback on the
tcp_handlersname. Please also note that UDP handlers are planned, so if this name is merged, it would probably also mean adding audp_handlerssection in the future.connect()TCP inbound handler cloudflare-docs#32443A picture of a cute animal (not mandatory, but encouraged)