[build] Prepare workerd for explicit libc++ linkage - #7025
Conversation
|
APIError: Invalid Anthropic API Key |
2 similar comments
|
APIError: Invalid Anthropic API Key |
|
APIError: Invalid Anthropic API Key |
|
@KirillTim Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
8da6ec0 to
6b80b22
Compare
Merging this PR will improve performance by 11.59%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
|
Seems reasonable - would like to discuss the overall motivation for this though. |
6b80b22 to
fc09d08
Compare
Yeah I think this merits some more discussion before moving forward with this approach – this adds complexity for every binary that doesn't use libc++, we should only do this if there's no better alternative. In particular, I think we can use LD_LIBRARY_PATH to avoid needing this. |
fc09d08 to
6361108
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7025 +/- ##
=======================================
Coverage 67.71% 67.71%
=======================================
Files 458 458
Lines 129341 129341
Branches 21144 21144
=======================================
Hits 87583 87583
Misses 28929 28929
Partials 12829 12829 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f358118 to
3881731
Compare
Edgeworker now supplies libc++ through link_extra_libs. For "rust_" targets it is supplied via "@@//deps:rust_runtime". Also disable helloworld_compile_test for debug builds, because it doesn't work with $ORIGIN relative libc++.so RUNPATH. Release note: None
3881731 to
9350d1f
Compare
| "//src/workerd/server:workerd", | ||
| ], | ||
| tags = ["no-qemu"], | ||
| target_compatible_with = select({ |
There was a problem hiding this comment.
Can you explain why this is needed? Add a comment or remove it if no longer needed
|
LGTM otherwise |
Edgeworker now supplies libc++ through link_extra_libs.
For "rust_" targets it is supplied via "@@//deps:rust_runtime".
Also disable helloworld_compile_test for debug builds, because
it doesn't work with $ORIGIN relative libc++.so RUNPATH.
Release note: None