fix(pages): preserve CJS globals in bundled dependencies - #2826
Draft
james-elicx wants to merge 1 commit into
Draft
fix(pages): preserve CJS globals in bundled dependencies#2826james-elicx wants to merge 1 commit into
james-elicx wants to merge 1 commit into
Conversation
commit: |
Contributor
|
Contributor
Performance benchmarksCompared 1 improved · 0 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
james-elicx
force-pushed
the
codex/fix-pages-bundled-cjs-globals
branch
from
August 6, 2026 10:25
69dfc6e to
0a4cfb8
Compare
james-elicx
force-pushed
the
codex/fix-pages-bundled-cjs-globals
branch
from
August 6, 2026 10:38
0a4cfb8 to
cb39205
Compare
Member
Author
|
/bigbonk review for issues |
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@james-elicx Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__dirnameand__filenamesemantics when Pages dependencies are converted for the Node dev module runnertype: moduleboundaries and avoid App Router, client, Cloudflare, and Nitro pathsRegression coverage
ReferenceError: __dirname is not definedValidation
tests/import-meta-url.test.tstests/build-optimization.test.tsvp check