test(pages): enable complex shallow routing coverage - #2770
Closed
james-elicx wants to merge 2 commits into
Closed
Conversation
commit: |
Contributor
|
Contributor
Performance benchmarksCompared 1 improved · 0 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Member
Author
|
Superseded by #2777. The three client-routing failures were the same Pages dev hydration-order bug: React handlers were not installed before browser load, rather than a separate shallow-router defect. The exact original no-wait cases pass under real Next.js and under #2777, which now carries all six affected no-wait regressions plus the gSSP timestamp assertion from this PR. Keeping this branch for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All three former fixmes shared one cause on current
main: Playwright could change the server-rendered<select>before React attached itsonChangehandler. The shallow router behavior itself now matches Next.js.Validation
vp check tests/e2e/pages-router-complex/client-routing.spec.ts{ shallow: false }fails on the render timestamp changingPLAYWRIGHT_PROJECT=pages-router-complex pnpm exec playwright test tests/e2e/pages-router-complex/client-routing.spec.ts --retries=0 --reporter=line(4 passed)PLAYWRIGHT_PROJECT=pages-router-complex pnpm exec playwright test --retries=0 --reporter=line(62 passed, 11 unrelated skipped)