Repository navigation
Add backup exclude options and defaults - #436
Closed
whoiskatrin wants to merge 1 commit into
Closed
whoiskatrin wants to merge 1 commit into
whoiskatrin wants to merge 1 commit into
Conversation
This adds end-to-end support for backup exclude patterns so users can skip dependency and build directories during createBackup. It also adds an excludeDefaults option for common paths and covers both exclude and default excludes with backup workflow E2E tests.
🦋 Changeset detectedLatest commit: 313c92e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Closing in favor of #437, which uses branch in this repository (no fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds end-to-end support for excluding files from backup archives.
createBackup()now supports:exclude: string[]for custom mksquashfs exclude patternsexcludeDefaults: booleanto include a default ignore setDefault excludes are:
node_modules,.git,dist,build,.next,.turbo,.cacheWhy
Backups currently include dependency and build directories by default,
which can make archives much larger than needed and slow down backup and
restore workflows.
API and behavior
BackupOptions.excludeis now wired through SDK -> DO -> container backupservice. Patterns are passed to
mksquashfs -ef(one pattern per line).excludeDefaultsdefaults tofalsefor backward-compatible behavior.Validation was added for
excludeandexcludeDefaultsinputs.Tests
Added two backup workflow E2E tests:
excludeexcludeDefaults: trueAlso ran local type checks through the pre-push hook.
Reviewer notes
This is intentionally minimal and keeps the existing backup flow. The
only functional flow change is passing an optional exclude file to
mksquashfs.