fix: keep slashes in model name for ai.run route - #2796
Open
gulybyte wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
ai.run()percent-encodes the/in the model slug, e.g.@cf/meta/llama-3.3-70b-instruct-fp8-fastbecomes@cf%2Fmeta%2Fllama-.... The Workers AI endpoint/accounts/{id}/ai/run/{model}requires the model name with literal/separators, so every request fails with:Root cause
The
pathtemplate tag used to build the route percent-encodes every path parameter (including/). Verified against the live API: the same request succeeds viacurland viaclient.post()with a plain string.Fix
Build the route with a plain string so the model name keeps its slashes.
account_idis a hex slug and safe as-is.Tests
Added
run: keeps / in model name unencoded— mocksfetch, asserts the full request URL contains the literal/separators. Prettier/eslint/tsc clean.