Feature: Endpoints\Zones cachePurge Prefixes Implementation#147
Open
spenserhale wants to merge 2 commits intocloudflare:masterfrom
Open
Feature: Endpoints\Zones cachePurge Prefixes Implementation#147spenserhale wants to merge 2 commits intocloudflare:masterfrom
spenserhale wants to merge 2 commits intocloudflare:masterfrom
Conversation
Adding prefixes parameter for clearning assets at URLs that match the prefix will be purged from the Cloudflare cache.
pmcgoverncw
reviewed
Mar 17, 2021
| return false; | ||
| } | ||
|
|
||
| public function cachePurge(string $zoneID, array $files = null, array $tags = null, array $hosts = null): bool |
There was a problem hiding this comment.
the cyclomatic complexity of this method hit 10 with these additions, causing CI to fail. Some functionality will need to be extracted into smaller methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing Prefixes optional parameter for purge_cache route.