Skip to content

fix: remove cacheDir override and node_modules CI caching #32587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mvvmm wants to merge 1 commit into
base: production
Choose a base branch
from
Draft

fix: remove cacheDir override and node_modules CI caching #32587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions .github/workflows/anchor-link-audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,8 @@ jobs:
node-version: 24.x
cache: pnpm

- name: Restore node_modules (cache hit)
id: node-modules-cache
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: node_modules
key: node-modules-${{ runner.os }}-node-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('package.json') }}

- name: Install node_modules (cache miss)
- name: Install dependencies
run: pnpm install --frozen-lockfile
if: steps.node-modules-cache.outputs.cache-hit != 'true'

- run: pnpm run build
env:
Expand All @@ -64,13 +56,6 @@ jobs:
./bin/htmltest -c ./bin/.htmltest.yml 2>&1 | grep -v "#_top" | tee /tmp/htmltest-filtered.txt || true
if grep -q "hash does not exist" /tmp/htmltest-filtered.txt; then exit 1; fi

- name: Save node_modules cache
if: always()
uses: actions/cache/save@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: node_modules
key: node-modules-${{ runner.os }}-node-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('package.json') }}

- name: Create issue on failure
if: ${{ failure() }}
env:
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/bigbonk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,8 @@ jobs:
node-version: 24.x
cache: pnpm

- name: Restore node_modules (cache hit)
id: node-modules-cache
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: node_modules
key: node-modules-${{ runner.os }}-node-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('package.json') }}

- name: Install node_modules (cache miss)
- name: Install dependencies
run: pnpm install --frozen-lockfile
if: steps.node-modules-cache.outputs.cache-hit != 'true'

- name: Run Bonk
uses: ask-bonk/ask-bonk/github@main
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/bonk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,8 @@ jobs:
node-version: 24.x
cache: pnpm

- name: Restore node_modules (cache hit)
id: node-modules-cache
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: node_modules
key: node-modules-${{ runner.os }}-node-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('package.json') }}

- name: Install node_modules (cache miss)
- name: Install dependencies
run: pnpm install --frozen-lockfile
if: steps.node-modules-cache.outputs.cache-hit != 'true'

- name: Run Lil Bonk
uses: ask-bonk/ask-bonk/github@main
Expand Down
52 changes: 6 additions & 46 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,8 @@ jobs:
exit 1
fi

- name: Restore node_modules (cache hit)
id: node-modules-cache
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: node_modules
key: node-modules-${{ runner.os }}-node-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('package.json') }}

- name: Install node_modules (cache miss)
- name: Install dependencies
run: pnpm install --frozen-lockfile
if: steps.node-modules-cache.outputs.cache-hit != 'true'

- name: Post codeowners comment
run: pnpm exec tsx bin/post-codeowners-comment/index.ts
Expand Down Expand Up @@ -135,22 +127,14 @@ jobs:
node-version: 24.x
cache: pnpm

- name: Restore node_modules (cache hit)
id: node-modules-cache
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: node_modules
key: node-modules-${{ runner.os }}-node-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('package.json') }}

- name: Install node_modules (cache miss)
- name: Install dependencies
run: pnpm install --frozen-lockfile
if: steps.node-modules-cache.outputs.cache-hit != 'true'

- name: Restore Astro assets from cache
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: |
.astro-cache/assets
node_modules/.astro/assets
key: astro-assets-${{ hashFiles('src/assets/**') }}
restore-keys: |
astro-assets-
Expand Down Expand Up @@ -204,16 +188,8 @@ jobs:
node-version: 24.x
cache: pnpm

- name: Restore node_modules (cache hit)
id: node-modules-cache
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: node_modules
key: node-modules-${{ runner.os }}-node-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('package.json') }}

- name: Install node_modules (cache miss)
- name: Install dependencies
run: pnpm install --frozen-lockfile
if: steps.node-modules-cache.outputs.cache-hit != 'true'

- name: Download artifact
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
Expand Down Expand Up @@ -250,16 +226,8 @@ jobs:
node-version: 24.x
cache: pnpm

- name: Restore node_modules (cache hit)
id: node-modules-cache
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: node_modules
key: node-modules-${{ runner.os }}-node-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('package.json') }}

- name: Install node_modules (cache miss)
- name: Install dependencies
run: pnpm install --frozen-lockfile
if: steps.node-modules-cache.outputs.cache-hit != 'true'

- name: Post PR CI failure comment
continue-on-error: true
Expand Down Expand Up @@ -293,16 +261,8 @@ jobs:
node-version: 24.x
cache: pnpm

- name: Restore node_modules (cache hit)
id: node-modules-cache
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: node_modules
key: node-modules-${{ runner.os }}-node-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('package.json') }}

- name: Install node_modules (cache miss)
- name: Install dependencies
run: pnpm install --frozen-lockfile
if: steps.node-modules-cache.outputs.cache-hit != 'true'

- name: Download artifact
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
Expand Down
12 changes: 2 additions & 10 deletions .github/workflows/publish-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,22 +26,14 @@ jobs:
node-version: 24.x
cache: pnpm

- name: Restore node_modules (cache hit)
id: node-modules-cache
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: node_modules
key: node-modules-${{ runner.os }}-node-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ hashFiles('package.json') }}

- name: Install node_modules (cache miss)
- name: Install dependencies
run: pnpm install --frozen-lockfile
if: steps.node-modules-cache.outputs.cache-hit != 'true'

- name: Restore Astro assets from cache
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
with:
path: |
.astro-cache/assets
node_modules/.astro/assets
key: astro-assets-${{ hashFiles('src/assets/**') }}
restore-keys: |
astro-assets-
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ distllms/
# generated types
.astro/

# Astro build cache
.astro-cache/

# skills/ is fetched from middlecache via bin/fetch-skills.ts
skills/
!.agents/skills/
Expand Down
3 changes: 1 addition & 2 deletions astro.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ export default defineConfig({
defaultStrategy: "hover",
},
outDir: "./dist",
cacheDir: ".astro-cache",
markdown,
image: {
service: {
Expand All @@ -291,7 +290,7 @@ export default defineConfig({
...appVite,
server: {
watch: {
ignored: ["**/dist/**", "**/.astro-cache/**"],
ignored: ["**/dist/**"],
},
},
},
Expand Down